Skip to content

Use correct error message for duplicate error key in product import#15980

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
denteblu:url-key-error-message
Jun 21, 2018
Merged

Use correct error message for duplicate error key in product import#15980
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
denteblu:url-key-error-message

Conversation

@denteblu
Copy link
Copy Markdown
Contributor

Description

During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the addRowError() call using the detailed error message.

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Jun 10, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@denteblu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @denteblu. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants